On Tue, 2009-12-08 at 07:49 -0800, michal wrote: > Roland Scheidegger pisze: > > On 08.12.2009 15:55, michal wrote: > > > >> This branch simplifies pipe/p_format.h by making enum pipe_format what > >> it should have been -- an enum. > >> > >> As a result there is no extra information encoded in it and one needs to > >> use auxiliary/util/u_format.h to get that info instead. Linking to the > >> auxiliary/util lib is necessary. > >> > >> Please review and if you can test if it doesn't break your setup, I will > >> appreciate it. > >> > >> I would like to hear from r300 and nouveau guys, as those drivers were > >> using some internal macros and I weren't 100% sure I got the conversion > >> right. > >> > > > > Looks nice, though it is unfortunately based on pre gallium-noblocks > > merge, so I suspect you'll get a conflict for almost every patch chunk > > at least in drivers if you try to merge it... > > > > > I didn't touch pipe blocks -- I left the pf_getblock* and friends in > pipe_format.h intact. > > How severe is the gallium-noblocks change? I would like to avoid mergin > master into this branch.
Merging the master into this branch is exactly the same as merging this branch into master. The only difference is that it allows people to review the merge before landing into master. I don't know if it makes much difference. I reviewed the changes in the branch, and at least the changes to the pipe interfaces and util module changes look good to me. This change was on my wishlist, so thanks for going ahead and doing it. Jose ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
