On 09.12.2009 18:58, michal wrote: > Keith Whitwell pisze: >> On Wed, 2009-12-09 at 09:16 -0800, michal wrote: >> >>> Hi all, >>> >>> I would like to merge this branch back to master this week. If anoyone >>> could test if the build works on his/her system, it would be nice. >>> >>> Thanks. >>> >> Michal, >> >> Can you detail what testing you've done on this branch and which >> environments you have/haven't built on? >> >> >> > Testing: > > * Capture the output of the old syntax parser and comapre with the > output of the new parser. No regressions found. Use a set of over 400 > shaders to perform the comparison. > > * Run GLSL Parser Test to see if the new parser successfully intergrates > with the rest of Mesa. No regressions found. > > So far I have been building that with scons on windows. I am planning to > fix the build with make and scons on linux. Seems to compile just fine now with make. Too bad all the strict-aliasing violations are still there (in grammar.c), I'll give this a look (but don't wait for it for merging). Also, there seems to be some char/byte uncleanliness, I get a gazillion warnings like: shader/grammar/grammar.c: In function ‘get_spec’: shader/grammar/grammar.c:1978: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness /usr/include/string.h:397: note: expected ‘const char *’ but argument is of type ‘byte *’ shader/grammar/grammar.c:1978: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness shader/grammar/grammar.c:1978: note: expected ‘const char *’ but argument is of type ‘byte *’ shader/grammar/grammar.c:1978: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness
Roland ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
