> > Seems to compile just fine now with make.
> > Too bad all the strict-aliasing violations are still there (in
> > grammar.c), I'll give this a look (but don't wait for it for merging).
> > Also, there seems to be some char/byte uncleanliness, I get a gazillion
> > warnings like:
> > shader/grammar/grammar.c: In function ‘get_spec’:
> > shader/grammar/grammar.c:1978: warning: pointer targets in passing
> > argument 1 of ‘strlen’ differ in signedness
> > /usr/include/string.h:397: note: expected ‘const char *’ but argument is
> > of type ‘byte *’
> > shader/grammar/grammar.c:1978: warning: pointer targets in passing
> > argument 1 of ‘__builtin_strcmp’ differ in signedness
> > shader/grammar/grammar.c:1978: note: expected ‘const char *’ but
> > argument is of type ‘byte *’
> > shader/grammar/grammar.c:1978: warning: pointer targets in passing
> > argument 1 of ‘strlen’ differ in signedness
> >
> >   
> Don't worry about it, Roland. This will go away once we merge (there's 
> still grammar dependency in the branch, but not any more in master).

If there are issues like this, it sounds like it makes sense to merge
master->branch now so that testers can get a better idea of the final
result.

We want to minimise the number of such merges, but when there is a real
need for them they are not prohibited...

Keith


------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to