Zack -- Impressive! Only one comment on patch #5 -- this is probably a util function rather than something for include/pipe. In particular we already have util/u_prim.h which has some similar functions in it -- I'd put this function there if possible...
Keith ________________________________________ From: Zack Rusin [za...@vmware.com] Sent: Thursday, December 24, 2009 5:24 AM To: mesa3d-dev Cc: Keith Whitwell; Michal Krol Subject: geometry shading patches yo, after our discussions i hacked a new version of geometry shading support in gallium. the new geometry shading syntax looks as follows: GEOM PROPERTY GS_INPUT_PRIMITIVE TRIANGLES PROPERTY GS_OUTPUT_PRIMITIVE TRIANGLE_STRIP DCL IN[][0], POSITION, CONSTANT DCL IN[][1], COLOR, CONSTANT DCL OUT[0], POSITION, CONSTANT DCL OUT[1], COLOR, CONSTANT 0:MOV OUT[0], IN[0][0] 1:MOV OUT[1], IN[0][1] 2:EMIT 3:MOV OUT[0], IN[1][0] 4:MOV OUT[1], IN[1][1] 5:EMIT 6:MOV OUT[0], IN[2][0] 7:MOV OUT[1], IN[2][1] 8:EMIT 9:ENDPRIM 10:END the attached patch series adds support for all of it throughout gallium (including support for 2dimensional arrays in tgsi_sanity checking, tgsi_dump and tgsi_text). Right now don't support switching of primitives in the draw module (e.g. input primitive being points and output primitive being a triangle_strip) but i'd like to do that after committing the attached changes (also the semantic for vertices which is a leftover from an old patch should be removed then if it's ok with you). Keith, most relevant patches for you are 0001 and 0005. Michal the most relevant to you are 0007, 0010, 0011 and 0012. z ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev