Brian Paul wrote: > Dave Airlie wrote: >> Just going down the r300g piglit failures and noticed fbo-drawbuffers >> failed, I've no idea >> if this passes on Intel hw, but it appears the texenvprogram really >> needs to understand the >> draw buffers. The attached patch fixes it here for me on r300g anyone >> want to test this on Intel >> with the piglit test before/after? > > The piglit test passes as-is with Mesa/swrast and NVIDIA. > > It fails with gallium/softpipe both with and w/out your patch. > > I think that your patch is on the right track. But multiple render > targets are still a bit of an untested area in the st/mesa code. > > One thing: the patch introduces a dependency on buffer state in the > texenvprogram code so in state.c we should check for the _NEW_BUFFERS flag. > > Otherwise, I'd like to debug the softpipe failure a bit further to see > what's going on. Perhaps you could hold off on committing this for a > bit...
OK, I found/fixed the problem in softpipe. I think your patch is good, but I think we should hold off on committing it to the 7.8 branch until it's tested a bit more (and not delay the 7.8.1 release). Other people should apply it and give it a try. -Brian ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
