On Tue, Apr 6, 2010 at 2:00 AM, Brian Paul <bri...@vmware.com> wrote:
> Dave Airlie wrote:
>>
>> Just going down the r300g piglit failures and noticed fbo-drawbuffers
>> failed, I've no idea
>> if this passes on Intel hw, but it appears the texenvprogram really
>> needs to understand the
>> draw buffers. The attached patch fixes it here for me on r300g anyone
>> want to test this on Intel
>> with the piglit test before/after?
>
> The piglit test passes as-is with Mesa/swrast and NVIDIA.
>
> It fails with gallium/softpipe both with and w/out your patch.
>
> I think that your patch is on the right track. But multiple render targets
> are still a bit of an untested area in the st/mesa code.
>
> One thing: the patch introduces a dependency on buffer state in the
> texenvprogram code so in state.c we should check for the _NEW_BUFFERS flag.
>
> Otherwise, I'd like to debug the softpipe failure a bit further to see
> what's going on. Perhaps you could hold off on committing this for a bit...
Well Eric pointed out to me the fun line in the spec
(3) Should gl_FragColor be aliased to gl_FragData[0]?
RESOLUTION: No. A shader should write either gl_FragColor, or
gl_FragData[n], but not both.
Writing to gl_FragColor will write to all draw buffers specified
with DrawBuffersARB.
So I was really just masking the issue with this. From what I can see
softpipe messes up and I'm not sure where we should be fixing this.
swrast does okay, its just whether we should be doing something in gallium
or in the drivers is open.
>From what I can see i965 + r300-r500 and at least nv40 from talking to Ben
would need fragment program changes to emit to each buffer instead.
Dave.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
