> On None, Alex Degtiar wrote: > > src/monitoring/proc_utils.hpp, line 59 > > <https://reviews.apache.org/r/3050/diff/1/?file=62807#file62807line59> > > > > I'm not convinced this should be in proc_utils, since the time is not > > actually read from proc. It is also used in non-Linux parts of the code, so > > it would conflict with proc_utils only being built in Linux. > > > > Any suggestions for where it should go, or an alternative to use?
Resolved by using Clock::now(). - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/#review3698 ----------------------------------------------------------- On 2011-12-08 00:00:32, Alex Degtiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3050/ > ----------------------------------------------------------- > > (Updated 2011-12-08 00:00:32) > > > Review request for mesos. > > > Summary > ------- > > The first of several patches related to resource usage monitoring. This patch > provides a collection of utilities for use on Linux for reading stats from > proc. It is used by both the lxc and proc resource collectors. > > > This addresses bug MESOS-89. > https://issues.apache.org/jira/browse/MESOS-89 > > > Diffs > ----- > > src/tests/Makefile.in ea943f7 > src/tests/proc_utils_tests.cpp PRE-CREATION > src/monitoring/proc_utils.cpp PRE-CREATION > src/Makefile.in 516f128 > src/monitoring/proc_utils.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/3050/diff > > > Testing > ------- > > Sanity tests have been written in src/tests/proc_utils_tests.cpp for all > utility functions, and functions have been tested ad hoc. > > > Thanks, > > Alex > >
