> On 2012-02-07 18:14:30, Charles Reiss wrote: > > > > Sam Whitlock wrote: > What target should these go into in Makefile.am? > libmesos_no_third_party_la_SOURCES seems to be the one that all the source > files are being added to. > > Charles Reiss wrote: > libmesos_no_third_party_la would be fine for the non-test targets. (The > test ones probably go into the mesos_tests_SOURCES.) > > > Sam Whitlock wrote: > Because some of the monitoring stuff is linux-specific, should it be > conditionally added to libmesos_no_third_party_la_SOURCES in the same way > lxc_isolation_module.cpp is? > > It seems like all the hpp files are unconditionally added to > libmesos_no_third_party and linux-specific cpp files should only be added if > OS_LINUX is true. Is this correct?
Yes. Yes, but don't forget to add it to EXTRA_DIST just ast in the lxc_isolation_module.cpp. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3050/#review4868 ----------------------------------------------------------- On 2011-12-24 04:13:40, Alex Degtiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3050/ > ----------------------------------------------------------- > > (Updated 2011-12-24 04:13:40) > > > Review request for mesos. > > > Summary > ------- > > The first of several patches related to resource usage monitoring. This patch > provides a collection of utilities for use on Linux for reading stats from > proc. It is used by both the lxc and proc resource collectors. > > > This addresses bug MESOS-89. > https://issues.apache.org/jira/browse/MESOS-89 > > > Diffs > ----- > > src/monitoring/linux/proc_utils.cpp PRE-CREATION > src/tests/Makefile.in ea943f7 > src/tests/proc_utils_tests.cpp PRE-CREATION > src/Makefile.in 516f128 > src/monitoring/linux/proc_utils.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/3050/diff > > > Testing > ------- > > Sanity tests have been written in src/tests/proc_utils_tests.cpp for all > utility functions, and functions have been tested ad hoc. > > > Thanks, > > Alex > >
