----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review12431 -----------------------------------------------------------
Ship it! Also, if you can rebase this that would be amazing! third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/7048/#comment26374> If you want the test below to always be testing what you expect, then I'd suggest factoring out this value into io.hpp as READ_SIZE or something similar and using that in the test. - Benjamin Hindman On Oct. 12, 2012, 9:56 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2012, 9:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > see above > > also: > -removed redundant length field from json > -added missing test for buffered io::read > > > Diffs > ----- > > src/files/files.cpp 6d41bf6649479f83b1f5f56665b555c0c553e713 > src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d > src/webui/master/static/jquery.pailer.js > edd23d9efa03086679af67a8bd13a273d409798b > third_party/libprocess/include/process/io.hpp > 722b15f11db4d3b6c941c8b4a6c5d395b11b035f > third_party/libprocess/src/process.cpp > e887feb1070cdd03a6d81b8f798145ed8bda7b5c > third_party/libprocess/src/tests.cpp > 9cae36aede41bc1e6bb966122c581cff97483717 > > Diff: https://reviews.apache.org/r/7048/diff/ > > > Testing > ------- > > make check on osx, and redhat > > mesos-local.sh to verify pailer > > > Thanks, > > Ben Mahler > >
