> On Oct. 10, 2012, 7:17 p.m., Vinod Kone wrote: > > src/tests/files_tests.cpp, line 105 > > <https://reviews.apache.org/r/7048/diff/2-5/?file=152777#file152777line105> > > > > checking on the body is nice but i suspect this is too brittle, when > > someone changes the response string.
This is borrowed from benh's tests (logging_tests.cpp). I think I also like checking the string because it ensures: 1. The request fails _for the correct reason_. 2. We're providing good diagnostic output to the end user. If someone changes the response string the test will fail, and they'll update it. :) > On Oct. 10, 2012, 7:17 p.m., Vinod Kone wrote: > > src/files/files.cpp, line 260 > > <https://reviews.apache.org/r/7048/diff/2-5/?file=152776#file152776line260> > > > > Is this cap documented somewhere for the users of read()? Maybe a > > warning is in order? This is documented in the pailer, in terms of what it expects of the read function provided to it. However, the documentation is lacking here, so I've updated each HTTP endpoint function documentation. Please read through the documentation I've added to the function signatures. Things are ok when this cap occurs, it's merely mimics how the read syscall behaves. Let me know what you think! > On Oct. 10, 2012, 7:17 p.m., Vinod Kone wrote: > > third_party/libprocess/src/tests.cpp, line 1233 > > <https://reviews.apache.org/r/7048/diff/2-5/?file=152779#file152779line1233> > > > > bad diff? hm.. looks like it! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review12316 ----------------------------------------------------------- On Oct. 10, 2012, 9:46 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2012, 9:46 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > see above > > also: > -removed redundant length field from json > -added missing test for buffered io::read > > > Diffs > ----- > > src/files/files.cpp 6d41bf6649479f83b1f5f56665b555c0c553e713 > src/tests/files_tests.cpp 764d2c7fdec4a21b9698eb4cb9e0673bd7f20e9d > src/webui/master/static/jquery.pailer.js > edd23d9efa03086679af67a8bd13a273d409798b > third_party/libprocess/include/process/io.hpp > 722b15f11db4d3b6c941c8b4a6c5d395b11b035f > third_party/libprocess/src/process.cpp > fde7154f9a4432acaff09849c0fa69c0694c9834 > third_party/libprocess/src/tests.cpp > 1cb26cd1729ce1cf0ed9573d3eb40690705d4b4e > > Diff: https://reviews.apache.org/r/7048/diff/ > > > Testing > ------- > > make check on osx, and redhat > > mesos-local.sh to verify pailer > > > Thanks, > > Ben Mahler > >
