----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review12316 -----------------------------------------------------------
Ship it! src/files/files.cpp <https://reviews.apache.org/r/7048/#comment26084> Is this cap documented somewhere for the users of read()? Maybe a warning is in order? src/tests/files_tests.cpp <https://reviews.apache.org/r/7048/#comment26085> checking on the body is nice but i suspect this is too brittle, when someone changes the response string. third_party/libprocess/src/tests.cpp <https://reviews.apache.org/r/7048/#comment26086> bad diff? - Vinod Kone On Oct. 10, 2012, 1:07 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2012, 1:07 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > see above > > also: > -removed redundant length field from json > -added missing test for buffered io::read > > > Diffs > ----- > > src/files/files.cpp c40b7b74485dc717c4291f17a4533b52f2c51a7e > src/tests/files_tests.cpp 17d284b82de4d9e1dedf1c26f4cedcf8269c4072 > src/webui/master/static/jquery.pailer.js > edd23d9efa03086679af67a8bd13a273d409798b > third_party/libprocess/include/process/io.hpp > 722b15f11db4d3b6c941c8b4a6c5d395b11b035f > third_party/libprocess/src/process.cpp > fde7154f9a4432acaff09849c0fa69c0694c9834 > third_party/libprocess/src/tests.cpp > 1df7ae61f24643a0ceab146646e77da6909dfd5f > > Diff: https://reviews.apache.org/r/7048/diff/ > > > Testing > ------- > > make check on osx, and redhat > > mesos-local.sh to verify pailer > > > Thanks, > > Ben Mahler > >
