> On Sept. 13, 2012, 7:24 p.m., Benjamin Hindman wrote: > > third_party/libprocess/src/process.cpp, line 3196 > > <https://reviews.apache.org/r/7048/diff/3/?file=153210#file153210line3196> > > > > PSA: As much as we are able, let's move towards std::tr1 and C++11 std > > (rather than Boost).
right, I used shared_array because tr1 and C++11 do not have an equivalent array handling shared_ptr (calling delete[] instead of delete) If I wrapped up this data into a struct: -I can now use a tr1 shared_ptr -I could use unique_ptr once we have std::move right? want me to add that struct now? > On Sept. 13, 2012, 7:24 p.m., Benjamin Hindman wrote: > > third_party/libprocess/src/process.cpp, lines 3174-3175 > > <https://reviews.apache.org/r/7048/diff/3/?file=153210#file153210line3174> > > > > const & so does this work only because bind makes a copy of the shared_ptr / shared_array? > On Sept. 13, 2012, 7:24 p.m., Benjamin Hindman wrote: > > src/files/files.cpp, line 172 > > <https://reviews.apache.org/r/7048/diff/3/?file=153207#file153207line172> > > > > const & see my question below about why this works below > On Sept. 13, 2012, 7:24 p.m., Benjamin Hindman wrote: > > src/files/files.cpp, line 177 > > <https://reviews.apache.org/r/7048/diff/3/?file=153207#file153207line177> > > > > This isn't complete. It's possible that some number of bytes n which is > > less than length will get returned and you'll want to keep reading the data > > until all of length has been read. true.. seems that io::read is not so useful for files given we typically we want it to handle the read loop for us how does this all tie in with vinod's async abstraction? do we want to use that, or expand our poll based io functions? (I'm asking because it seems we are in need of a new io::read that has a read loop in it, trying to read a minimum amount of data) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7048/#review11491 ----------------------------------------------------------- On Sept. 13, 2012, 2:57 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7048/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2012, 2:57 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > see above > > also: > -removed redundant length field from json > -added missing test for buffered io::read > > > Diffs > ----- > > src/files/files.cpp 806aa35 > src/tests/files_tests.cpp 6ef2004 > src/webui/master/static/jquery.pailer.js edd23d9 > third_party/libprocess/src/process.cpp 2d2b56c > third_party/libprocess/src/tests.cpp 41bf973 > > Diff: https://reviews.apache.org/r/7048/diff/ > > > Testing > ------- > > make check on osx, and redhat > > mesos-local.sh to verify pailer > > > Thanks, > > Ben Mahler > >
