----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8415/#review14326 -----------------------------------------------------------
It might be nice to add a comment explaining why you had to factor out the operators so somebody doesn't try and put them back inside the class. src/linux/proc.hpp <https://reviews.apache.org/r/8415/#comment30503> You lost the formatting from above (s/operator==/operator ==/). src/linux/proc.hpp <https://reviews.apache.org/r/8415/#comment30504> Ditto. src/tests/cgroups_isolation_tests.cpp <https://reviews.apache.org/r/8415/#comment30505> Just curious, what was the warning? - Benjamin Hindman On Dec. 7, 2012, 6:06 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8415/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2012, 6:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > The new proc code has issues compiling on Ubuntu 10.04 with gcc 4.4.3. > > There is a known issue in this gcc version with false warnings of this type: > ../../src/linux/proc.hpp: In member function ‘virtual void > CgroupsCpusetTest_ManyCPUManyCpusets_Test::TestBody()’: > ../../src/linux/proc.hpp:81: error: dereferencing pointer ‘<anonymous>’ does > break strict-aliasing rules > ../../src/linux/proc.hpp:86: error: dereferencing pointer ‘<anonymous>’ does > break strict-aliasing rules > ../../src/linux/proc.hpp:76: error: dereferencing pointer ‘<anonymous>’ does > break strict-aliasing rules > /usr/include/c++/4.4/bits/stl_tree.h:175: note: initialized from here > > > Diffs > ----- > > src/linux/proc.hpp 6c84a73ab1c4d6893390f96eae15422c21001328 > src/tests/cgroups_isolation_tests.cpp > 41d6ac9d6331bcfd1e57d403e13a1d27cd5d14bc > > Diff: https://reviews.apache.org/r/8415/diff/ > > > Testing > ------- > > make check on Ubuntu 10.04 > > > Thanks, > > Ben Mahler > >
