> On Dec. 11, 2012, 11:26 p.m., Benjamin Hindman wrote: > > It might be nice to add a comment explaining why you had to factor out the > > operators so somebody doesn't try and put them back inside the class.
I actually didn't need to factor it out, I ended up doing that originally in an effort to silence the warning but it was unrelated. I kept is this way because I see that looks like the idiomatic way to to it in C++, if you prefer it to be in the class I can revert it. > On Dec. 11, 2012, 11:26 p.m., Benjamin Hindman wrote: > > src/tests/cgroups_isolation_tests.cpp, line 70 > > <https://reviews.apache.org/r/8415/diff/1/?file=235787#file235787line70> > > > > Just curious, what was the warning? See the review description. I ended up using binary search with commenting to find what line in this file triggers the warning in the proc code. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8415/#review14326 ----------------------------------------------------------- On Dec. 7, 2012, 6:06 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8415/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2012, 6:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > The new proc code has issues compiling on Ubuntu 10.04 with gcc 4.4.3. > > There is a known issue in this gcc version with false warnings of this type: > ../../src/linux/proc.hpp: In member function ‘virtual void > CgroupsCpusetTest_ManyCPUManyCpusets_Test::TestBody()’: > ../../src/linux/proc.hpp:81: error: dereferencing pointer ‘<anonymous>’ does > break strict-aliasing rules > ../../src/linux/proc.hpp:86: error: dereferencing pointer ‘<anonymous>’ does > break strict-aliasing rules > ../../src/linux/proc.hpp:76: error: dereferencing pointer ‘<anonymous>’ does > break strict-aliasing rules > /usr/include/c++/4.4/bits/stl_tree.h:175: note: initialized from here > > > Diffs > ----- > > src/linux/proc.hpp 6c84a73ab1c4d6893390f96eae15422c21001328 > src/tests/cgroups_isolation_tests.cpp > 41d6ac9d6331bcfd1e57d403e13a1d27cd5d14bc > > Diff: https://reviews.apache.org/r/8415/diff/ > > > Testing > ------- > > make check on Ubuntu 10.04 > > > Thanks, > > Ben Mahler > >
