----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8415/ -----------------------------------------------------------
(Updated Dec. 12, 2012, 6:51 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes ------- Syntax formatting from benh review. Description ------- The new proc code has issues compiling on Ubuntu 10.04 with gcc 4.4.3. There is a known issue in this gcc version with false warnings of this type: ../../src/linux/proc.hpp: In member function ‘virtual void CgroupsCpusetTest_ManyCPUManyCpusets_Test::TestBody()’: ../../src/linux/proc.hpp:81: error: dereferencing pointer ‘<anonymous>’ does break strict-aliasing rules ../../src/linux/proc.hpp:86: error: dereferencing pointer ‘<anonymous>’ does break strict-aliasing rules ../../src/linux/proc.hpp:76: error: dereferencing pointer ‘<anonymous>’ does break strict-aliasing rules /usr/include/c++/4.4/bits/stl_tree.h:175: note: initialized from here Diffs (updated) ----- src/linux/proc.hpp 6c84a73ab1c4d6893390f96eae15422c21001328 src/tests/cgroups_isolation_tests.cpp 41d6ac9d6331bcfd1e57d403e13a1d27cd5d14bc Diff: https://reviews.apache.org/r/8415/diff/ Testing ------- make check on Ubuntu 10.04 Thanks, Ben Mahler
