-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9408/#review16526
-----------------------------------------------------------



src/tests/balloon_framework_test.sh
<https://reviews.apache.org/r/9408/#comment35052>

    I think you can say `trap cleanup EXIT` and avoid all these atexit calls. 
You could also move the master and slave pid cleanup into the cleanup function, 
no?


- David Mackey


On Feb. 13, 2013, 7:24 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9408/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 7:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/tests/balloon_framework_test.sh 
> 93a733f64cfde08349b7781eb3d5e13594c74498 
> 
> Diff: https://reviews.apache.org/r/9408/diff/
> 
> 
> Testing
> -------
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Balloon*" --verbose
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to