-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9408/#review16557
-----------------------------------------------------------



src/slave/cgroups_isolation_module.hpp
<https://reviews.apache.org/r/9408/#comment35128>

    Can you use a more descriptive name here?
    
    e.g.
    lock
    advisoryLock


- Ben Mahler


On Feb. 14, 2013, 1:38 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9408/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 1:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.hpp 
> 669efa14ba2603764aa68ae19a44e79dbfdec192 
>   src/slave/cgroups_isolation_module.cpp 
> 14f549edaf1b37a6bca8f75309864333ae775e7c 
>   src/slave/process_based_isolation_module.hpp 
> f1817192582e3646f8dcf17934ba7998829e8fd6 
>   src/slave/process_based_isolation_module.cpp 
> 12a579cba56cd3dac384bc7919b0d5537b0e429d 
>   src/tests/balloon_framework_test.sh 
> 93a733f64cfde08349b7781eb3d5e13594c74498 
> 
> Diff: https://reviews.apache.org/r/9408/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to