> On Feb. 13, 2013, 9:36 p.m., David Mackey wrote: > > src/tests/balloon_framework_test.sh, line 74 > > <https://reviews.apache.org/r/9408/diff/2/?file=258586#file258586line74> > > > > Sorry, I overlooked the implementation support/atexit.sh. But, > > registering with atexit only once should be enough now that the cleanup > > function exists. > > Also, if you make the call to kill similar to line 59's `kill -0 > > ${SLAVE_PID} >/dev/null 2>&1` then it's really okay if you don't know the > > pid as ${SLAVE_PID} will be empty and kill essentially will be a noop. (It > > will technically print it's help text which gets redirected to /dev/null.) > > > > > > > >
done - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16531 ----------------------------------------------------------- On Feb. 13, 2013, 7:24 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 7:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Balloon*" --verbose > > > Thanks, > > Vinod Kone > >
