> On Feb. 13, 2013, 8:28 p.m., David Mackey wrote: > > src/tests/balloon_framework_test.sh, line 74 > > <https://reviews.apache.org/r/9408/diff/2/?file=258586#file258586line74> > > > > I think you can say `trap cleanup EXIT` and avoid all these atexit > > calls. You could also move the master and slave pid cleanup into the > > cleanup function, no? > > Vinod Kone wrote: > atexit is just a wrapper around trap. so, i'm not sure what's the benefit > of doing trap cleanup? also, i can't move master and slave pid cleanup > inside, because I don't know their pids in advance. though, i guess i could > just check if those pids are valid and then pass it to atexit.
Inline review board commenting confuses me, please see my other comment. In summary, either way is fine by me. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16526 ----------------------------------------------------------- On Feb. 13, 2013, 7:24 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 7:24 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Balloon*" --verbose > > > Thanks, > > Vinod Kone > >
