> On April 12, 2013, midnight, Ben Mahler wrote: > >
It is a good practice to send these comments out at the same time as you update the review, that way we can read the comments and do another review at the same time. > On April 12, 2013, midnight, Ben Mahler wrote: > > third_party/libprocess/src/tests/statistics_tests.cpp, line 60 > > <https://reviews.apache.org/r/10421/diff/1/?file=280464#file280464line60> > > > > Thanks to your earlier change, we now have the arithmetic operators, so: > > > > advance(Days(1) + Seconds(1)) > > Jiang Yan Xu wrote: > This commit precedes that Duration change, so this will be taken care of > in that commit. Was there a reason that this precedes it? If not, you can just rebase -i and re-order them. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10421/#review19043 ----------------------------------------------------------- On April 11, 2013, 7:10 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10421/ > ----------------------------------------------------------- > > (Updated April 11, 2013, 7:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > bfb30344ca02cd42c442a373d44d6a3fa287c1e3 > src/tests/gc_tests.cpp 8c2e6e137748b9c8fa3db826752bed6a03c6c92f > src/tests/log_tests.cpp a0a4b4aea4d47b83f14f140523d0e7317f069a63 > src/tests/master_tests.cpp 1581abcd7e2775672c5cde14cb1052ced5f34376 > src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe > src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b > src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e > src/tests/status_update_manager_tests.cpp > a355ecd09a0462e701707862ceb62584826a4e5e > src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef > third_party/libprocess/include/process/clock.hpp > be96a68de7257f0ec0a292be1f3357d089397a51 > third_party/libprocess/src/process.cpp > b4f27077f70468276b9a2f2cbce26036449b5b96 > third_party/libprocess/src/tests/process_tests.cpp > 53ade66c9d2dad8ffed2d322665291566acb4c84 > third_party/libprocess/src/tests/statistics_tests.cpp > 6efcc8004fc637e5c4dc8f0ba0e34c0a06a8c052 > > Diff: https://reviews.apache.org/r/10421/diff/ > > > Testing > ------- > > make check. > Stopped at AllocatorZooKeeperTest, the same place where trunk failed. > > > Thanks, > > Jiang Yan Xu > >
