----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10421/#review19142 -----------------------------------------------------------
third_party/libprocess/include/process/clock.hpp <https://reviews.apache.org/r/10421/#comment39699> We can almost kill this TODO ;) Are you planning on also taking care of Clock::now() at some point? third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/10421/#comment39700> Since this is now not a template, this is named more appropriately as: s/fixedprecision/doublePrecision/ The intent of this looks to be a generic template for setting precision, but I see it's only used for doubles, correct? If so, I think it's cleaner to rename this. - Ben Mahler On April 13, 2013, 7:03 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10421/ > ----------------------------------------------------------- > > (Updated April 13, 2013, 7:03 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/include/process/clock.hpp > be96a68de7257f0ec0a292be1f3357d089397a51 > third_party/libprocess/src/process.cpp > b4f27077f70468276b9a2f2cbce26036449b5b96 > third_party/libprocess/src/tests/process_tests.cpp > 53ade66c9d2dad8ffed2d322665291566acb4c84 > third_party/libprocess/src/tests/statistics_tests.cpp > 6efcc8004fc637e5c4dc8f0ba0e34c0a06a8c052 > > Diff: https://reviews.apache.org/r/10421/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
