> On April 15, 2013, 6:53 p.m., Ben Mahler wrote: > > third_party/libprocess/src/process.cpp, line 578 > > <https://reviews.apache.org/r/10421/diff/4/?file=281302#file281302line578> > > > > Also note that Duration has an output operator (<<) in duration.hpp. > > Meaning the following will work: > > > > VLOG(2) << "Clock advanced (" << duration << ")"; > > > > Can you update the output operator there to use full double precision? > > (We'll have a cleaner implementation when we refactor to use integral time > > values).
Fixed Duration in https://reviews.apache.org/r/10422/ and updated process.cpp in this commit. Will clean up more after changing Clock::now to use Duration. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10421/#review19208 ----------------------------------------------------------- On April 15, 2013, 10:53 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10421/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 10:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/include/process/clock.hpp > be96a68de7257f0ec0a292be1f3357d089397a51 > third_party/libprocess/src/process.cpp > d3dfe806aeb18d495717a07c555bd628d0ee88b7 > third_party/libprocess/src/tests/process_tests.cpp > 562f52c6833183e6e4e81f6ae307cf28e40404b3 > third_party/libprocess/src/tests/statistics_tests.cpp > 6efcc8004fc637e5c4dc8f0ba0e34c0a06a8c052 > > Diff: https://reviews.apache.org/r/10421/diff/ > > > Testing > ------- > > make check. > > Also VLOG output is checked manually: > Sample output: > I0415 22:11:53.476338 30680 process.cpp:575] Clock advanced > (5.000000000000000secs) to 1366063918.476197004318237 > I0415 22:11:53.476485 30697 process.cpp:623] Clock of (1)@x.x.x.x:46308 > updated to 2258.703568909055775weeks > > > Thanks, > > Jiang Yan Xu > >
