----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10744/#review19636 -----------------------------------------------------------
src/slave/reaper.hpp <https://reviews.apache.org/r/10744/#comment40540> Kill this. We don't usually do this in header files. Use process::Future explicitly where needed. src/slave/reaper.hpp <https://reviews.apache.org/r/10744/#comment40543> Can you pull this down after Reaper class. That has been our convention. You might need a forward declaration of Reaper process. src/slave/reaper.hpp <https://reviews.apache.org/r/10744/#comment40542> Add a comment here saying "Reaper implementation". That would explain why you didn't comment the public methods here. src/slave/reaper.hpp <https://reviews.apache.org/r/10744/#comment40541> s/TOOD/TODO/ src/slave/reaper.cpp <https://reviews.apache.org/r/10744/#comment40544> Why Future<Nothing> instead of Try<Nothing>? src/slave/reaper.cpp <https://reviews.apache.org/r/10744/#comment40545> revert if the above is reverted to Try src/slave/reaper.cpp <https://reviews.apache.org/r/10744/#comment40546> new line - Vinod Kone On April 24, 2013, 12:30 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10744/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 12:30 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > > Diff: https://reviews.apache.org/r/10744/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
