----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10744/#review19871 -----------------------------------------------------------
src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/10744/#comment40986> Why is this still a pointer? src/slave/process_isolator.cpp <https://reviews.apache.org/r/10744/#comment40987> Ditto src/slave/reaper.hpp <https://reviews.apache.org/r/10744/#comment40990> Can you move this under Reaper? If exposing the underlying Process in the header, we typically place it below the API, e.g.: src/slave/gc.hpp src/slave/monitor.hpp src/slave/reaper.cpp <https://reviews.apache.org/r/10744/#comment40991> Looks like this destructor is not necessary? - Ben Mahler On April 26, 2013, 7:50 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10744/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 7:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > > Diff: https://reviews.apache.org/r/10744/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
