> On April 29, 2013, 5:49 p.m., Ben Mahler wrote: > > src/slave/reaper.cpp, line 49 > > <https://reviews.apache.org/r/10744/diff/2/?file=285025#file285025line49> > > > > Looks like this destructor is not necessary? > > Jiang Yan Xu wrote: > Thanks for the examples above, I think I should discard all the futures > the same way GarbageCollectorProcess does it? > > GarbageCollectorProcess::~GarbageCollectorProcess() > { > foreachvalue (const PathInfo& info, paths) { > info.promise->future().discard(); > } > } > > Jiang Yan Xu wrote: > I am sorry the clean-up is in the Process class, not the wrapper. I'll > delete the destructor.
Clearly I wasn't awake yet... Ignore the last reply. I am adding promise.future().discard()s to the ReaperProcess destructor. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10744/#review19871 ----------------------------------------------------------- On April 26, 2013, 7:50 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10744/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 7:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > > Diff: https://reviews.apache.org/r/10744/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
