> On April 24, 2013, 6:52 p.m., Vinod Kone wrote:
> > third_party/libprocess/third_party/stout/include/stout/proc.hpp, lines 38-39
> > <https://reviews.apache.org/r/10745/diff/1/?file=283953#file283953line38>
> >
> >     Can you expand a bit more on when it is unreliable?

In the OpenGroup page: 
http://pubs.opengroup.org/onlinepubs/009695399/functions/kill.html
"In particular, this means that an application cannot have a parent process 
check for termination of a particular child with kill()."

In our test cases I've found that kill(pid, 0) returns 0 for a terminated grand 
child but not for a terminated child. But with only this evidence I was 
reluctant to say either "proc::alive() fails to detect termination of a child 
but works with grand child processes" or "It fails to detect termination of a 
child but works with non-child processes". I haven't found enough info online 
that confirm either statement.

Suggestion?

Perhaps I can add the (part of) above lines to the comment?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10745/#review19638
-----------------------------------------------------------


On April 24, 2013, 12:31 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10745/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 12:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/proc.hpp 
> 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46 
> 
> Diff: https://reviews.apache.org/r/10745/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to