----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10745/#review19660 -----------------------------------------------------------
Ship it! third_party/libprocess/third_party/stout/include/stout/proc.hpp <https://reviews.apache.org/r/10745/#comment40603> First say what this function does, so: // Returns whether the process is alive. third_party/libprocess/third_party/stout/include/stout/proc.hpp <https://reviews.apache.org/r/10745/#comment40604> s/ or/, or/ I would also indent the 1) and 2) lines by 2 spaces, but up to you. - Ben Mahler On April 24, 2013, 12:31 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10745/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 12:31 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/proc.hpp > 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46 > > Diff: https://reviews.apache.org/r/10745/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Jiang Yan Xu > >
