> On April 24, 2013, 11:55 p.m., Jiang Yan Xu wrote: > > third_party/libprocess/third_party/stout/include/stout/proc.hpp, line 40 > > <https://reviews.apache.org/r/10745/diff/1/?file=283953#file283953line40> > > > > Since it doesn't check for termination but rather validity (including > > dead/zombie processes) of a PID, we should probably call it valid instead > > of alive to avoid confusion, right? > > Vinod Kone wrote: > i'm not particularly worried, but i will let you make the call. > > Ben Mahler wrote: > I think alive is ok, but valid might actually be more semantically > correct: > "If sig is 0 (the null signal), error checking is performed but no signal > is actually sent. The null signal can be used to check the __validity__ of > pid." > > Calling this valid will force the callers to figure out what "valid" > means, so that's a positive at least.
OK, I am keeping the 'alive' wording because 'valid' sounds more related to the PID than the process. I added a comment that it includes the inactive/zombie/terminated state and do not confuse with 'active', which means it's running/stopped. This could be later optimized/clarified if we are going to use /proc on Linux for process state checking. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10745/#review19682 ----------------------------------------------------------- On April 26, 2013, 7:51 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10745/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 7:51 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 4d51693504f15236c131600737d0b6ddb6a1a819 > third_party/libprocess/third_party/stout/include/stout/proc.hpp > 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46 > > Diff: https://reviews.apache.org/r/10745/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Jiang Yan Xu > >
