> On April 24, 2013, 8:25 p.m., Benjamin Hindman wrote: > > src/slave/cgroups_isolator.cpp, line 553 > > <https://reviews.apache.org/r/10746/diff/1/?file=283963#file283963line553> > > > > Can we s/PID<CgroupsIsolator>(this)/self()/ or > > s/PID<CgroupsIsolator>(this)/this/ now (here and everywhere else)?
Unfortunately neither worked... Error with self(): ../../src/slave/cgroups_isolator.cpp:553: error: no matching function for call to 'defer(process::PID<mesos::internal::slave::Isolator>, void (mesos::internal::slave::CgroupsIsolator::*)(pid_t, const process::Future<Option<int> >&), pid_t&, std::tr1::_Placeholder<1>&)' Error this this: ../../src/slave/cgroups_isolator.cpp:553: error: no matching function for call to 'defer(mesos::internal::slave::CgroupsIsolator* const, void (mesos::internal::slave::CgroupsIsolator::*)(pid_t, const process::Future<Option<int> >&), pid_t&, std::tr1::_Placeholder<1>&)' Our guesses were that CgroupsIsolator itself doesn't directly derive from Process<T> but indirectly through "class Isolator : public process::Process<Isolator>". "PID<CgroupsIsolator>(this)" is still fine, right? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10746/#review19651 ----------------------------------------------------------- On April 24, 2013, 12:43 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10746/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 12:43 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > - Previously the listener was notified when its child processes terminate > whether it register them or not. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > src/tests/utils.hpp ffe637f2f03ff5ca020a4d2cb617be047aade034 > > Diff: https://reviews.apache.org/r/10746/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
