Re: Review Request: Changed reaper to use Future as the notification mechanism. The notification is now sent only if the pid is explicitly registered via the monitor() call.

[Ben Mahler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10746/#review19881
-----------------------------------------------------------



src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/10746/#comment41009>

    Can you add a little more context to the logging?
    
    "Failed to monitor " << pid << ": " << status.isDiscarded() ? "discarded" : 
status.failure();
    
    With the ternary you can catch both cases:
    if (!status.ready()) {
      ...
    }



src/slave/process_isolator.cpp
<https://reviews.apache.org/r/10746/#comment41010>

    Ditto



src/slave/reaper.cpp
<https://reviews.apache.org/r/10746/#comment41012>

    So if the process does not exist, you'll set up the promise here and it 
will later become ready when the reap() occurs?
    
    Seems that you want to directly return either:
      -An empty Option (-1 in this review), or
      -A failure
    
    Thoughts?



src/slave/reaper.cpp
<https://reviews.apache.org/r/10746/#comment41013>

    Nice comment, what happens when these conditions aren't met?



src/slave/reaper.cpp
<https://reviews.apache.org/r/10746/#comment41014>

    Do you mean if the child terminates before we check if it's alive()? Either 
way, I think you can kill this comment.



src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/10746/#comment41015>

    Kill this comment, since the spawn'ing happens under the hood now :)



src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/10746/#comment41027>

    no need to store it in a variable..?
    
    ASSERT_TRUE(WIFSIGNALED(status.get()));
    ASSERT_EQ(SIGKILL, WTERMSIG(status.get()));



src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/10746/#comment41029>

    Kill this comment since the spawn is internal.



src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/10746/#comment41030>

    newline



src/tests/reaper_tests.cpp
<https://reviews.apache.org/r/10746/#comment41026>

    ditto


- Ben Mahler


On April 29, 2013, 7:31 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10746/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 7:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> - Previously the listener was notified when its child processes terminate 
> whether it register them or not. 
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 
>   src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 
>   src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 
>   src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 
>   src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 
>   src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 
>   src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 
>   src/tests/utils.hpp ca3ecd7f0cab283327bf83e57d4b405b4ada9c74 
> 
> Diff: https://reviews.apache.org/r/10746/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>