----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10746/#review19803 -----------------------------------------------------------
partial review. src/slave/reaper.cpp <https://reviews.apache.org/r/10746/#comment40838> kill src/slave/reaper.cpp <https://reviews.apache.org/r/10746/#comment40839> expand on the comment that we are failing here because it is neither a child nor do we have perms src/slave/reaper.cpp <https://reviews.apache.org/r/10746/#comment40840> Make a comment on your invariants here. Also CHECK them. src/slave/reaper.cpp <https://reviews.apache.org/r/10746/#comment40841> Swap these, so that you can first reap for children and then reap non-children. that way you only need one waitpid() - Vinod Kone On April 26, 2013, 7:53 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10746/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 7:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > - Previously the listener was notified when its child processes terminate > whether it register them or not. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > src/tests/utils.hpp ffe637f2f03ff5ca020a4d2cb617be047aade034 > > Diff: https://reviews.apache.org/r/10746/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
