Re: Review Request: Changed reaper to use Future as the notification mechanism. The notification is now sent only if the pid is explicitly registered via the monitor() call.

[Jiang Yan Xu]

> On April 26, 2013, 9:29 p.m., Vinod Kone wrote:
> > src/slave/reaper.cpp, line 119
> > <https://reviews.apache.org/r/10746/diff/2/?file=285035#file285035line119>
> >
> >     Make a comment on your invariants here.
> >     
> >     Also CHECK them.

Commented on the assumption, no CHECK can be added.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10746/#review19803
-----------------------------------------------------------


On April 29, 2013, 7:31 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10746/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 7:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> - Previously the listener was notified when its child processes terminate 
> whether it register them or not. 
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 
>   src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 
>   src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 
>   src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 
>   src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 
>   src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 
>   src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 
>   src/tests/utils.hpp ca3ecd7f0cab283327bf83e57d4b405b4ada9c74 
> 
> Diff: https://reviews.apache.org/r/10746/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>