On 07/04/2017 11:53, Esponde, Joel wrote:


For this kind of very small issue, is it sufficient to send just an
email like this?

Or do I need to follow any patch based workflow?



This reminds me of an issue I ran into with the same package. It failed
with QA issues:

ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA Issue:
No GNU_HASH in the elf binary:
'/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary:
'/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/sdimage'
[ldflags]

I don't think it is worthwhile to fix the source, so I would propose to
add to the recipe:

INSANE_SKIP_${PN} += "ldflags"

Attached patch (including the typo fix) tested against current state of
Morty.

Cheers,

Bas.

- Fix typo in download protocol (found by Joel Esponde)
- Mitigate QA issue not worthwhile to fix:

ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA Issue: No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/sdimage' [ldflags]

Solved by adding INSANE_SKIP to recipe.


Found-by: Joel Esponde <joel.espo...@honeywell.com>
Signed-off-by: Bas Mevissen <bas.mevis...@emcodev.nl>
diff --git a/recipes-bsp/imx-uuc/imx-uuc_git.bb b/recipes-bsp/imx-uuc/imx-uuc_git.bb
index 6fb838a..4b3de09 100644
--- a/recipes-bsp/imx-uuc/imx-uuc_git.bb
+++ b/recipes-bsp/imx-uuc/imx-uuc_git.bb
@@ -8,10 +8,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 inherit autotools-brokensep
 
+INSANE_SKIP_${PN} += "ldflags"
+
 PR = "r1"
 PV = "0.5.1+git${SRCPV}"
 
-SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocal=https"
+SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocol=https"
 SRCREV = "3440b1108373e79669cc17ba1d2be91a123a2053"
 
 S = "${WORKDIR}/git"

-- 
_______________________________________________
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Reply via email to