[ http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12434874 ] Trustin Lee commented on DIRMINA-162: -------------------------------------
Greg, thank you again! :) 1. The reason I talked about IdentityHashMap was just about the case when a key is an IoSession. We have to use HashMap for SocketAddresses, of course. 2. Oh yeah I have to update IoHandler. 3. I think ExpiringSessionRecycler should be the default recycler because NOOP can cause a lot of overhead. 4. startExpiring() could be called automatically at the first invocation to put(). Everything's fine except that! If you are willing to submit the newer patch, then you could update IoHandler documentation and take care of other stuff I mentioned in this comment. Please let me know if not, then I will take care of it. :D > datagram session management fails > --------------------------------- > > Key: DIRMINA-162 > URL: http://issues.apache.org/jira/browse/DIRMINA-162 > Project: Directory MINA > Issue Type: Bug > Affects Versions: 0.9 > Reporter: Rainer Bieniek > Assigned To: Trustin Lee > Priority: Minor > Fix For: 1.0 > > Attachments: mina-datagram-session-management-v2.diff, > mina-datagram-session-management-v3.diff, > mina-datagram-session-management-v4.diff, > mina-datagram-session-management-v5.diff, > mina-datagram-session-management.diff > > > As of mina 0.9.0 the session management does not work in various ways: > - a new session is created per received package. The worker thread does not > cache created session but only assign the select key to the session and drops > it after processing the package. It would be better to attach the session to > the RegistrationRequest and check it while processing the received package. > - the provided IoFilterChainBuilder does get applied to the created datagram > session. It is cached in the RegistrationRequest but not used on the session > - The sessionClose lifecycle event is not applied on the session either. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
