[ http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12436090 ] Trustin Lee commented on DIRMINA-162: -------------------------------------
Hi Greg, thanks for the patch again! I applied it successfully, but I'd like to mention a few tiny problems: * Please don't auto-format the code. It makes me really hard to review the patch. * Please run all unit tests before submitting a patch. I found the test fails due to a bug in ExpiringMap. It was a trivial one, so I fixed it fairly easily. Except that, it's very good. Here's the list of modifications I made on top of your patch: * Changed the type of TTL and expiration interval to integer. * ExpirationSessionRecycler doesn't implement ExpirationListener directly. I made an inner class instead. * Removed the static getInstance() method in ExpiringSessionRecycler because we are already using a static global expirer by default. We need some documentation on creating many recyclers though. Thank you again! > datagram session management fails > --------------------------------- > > Key: DIRMINA-162 > URL: http://issues.apache.org/jira/browse/DIRMINA-162 > Project: Directory MINA > Issue Type: Bug > Affects Versions: 0.9 > Reporter: Rainer Bieniek > Assigned To: Trustin Lee > Priority: Minor > Fix For: 1.0 > > Attachments: mina-datagram-session-management-v2.diff, > mina-datagram-session-management-v3.diff, > mina-datagram-session-management-v4.diff, > mina-datagram-session-management-v5.diff, > mina-datagram-session-management-v6.diff, > mina-datagram-session-management-v7.diff, > mina-datagram-session-management.diff > > > As of mina 0.9.0 the session management does not work in various ways: > - a new session is created per received package. The worker thread does not > cache created session but only assign the select key to the session and drops > it after processing the package. It would be better to attach the session to > the RegistrationRequest and check it while processing the received package. > - the provided IoFilterChainBuilder does get applied to the created datagram > session. It is cached in the RegistrationRequest but not used on the session > - The sessionClose lifecycle event is not applied on the session either. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
