On 09/11/13 10:22, Kai Tietz wrote: > 2013/9/11 Jacek Caban <[email protected]>: >> On 09/10/13 20:35, Jacek Caban wrote: >>> On 9/10/13 8:25 PM, Erik van Pienbroek wrote: >>>> wine-gecko: >>>> ----------- >>>> >>>> ../../widget/windows/JumpListBuilder.o: In function >>>> `ZN7mozilla6widget15JumpListBuilderC2Ev': >>>> /builddir/build/BUILD/mingw-wine-gecko-2.21/wine-mozilla-2.21/widget/windows/JumpListBuilder.cpp:54: >>>> undefined reference to `IID_ICustomDestinationList' >>>> >>>> This one is new (it wasn't visible yet due to earlier failures). This >>>> one is declared in shobjidl.h as part of a DEFINE_GUID macro, but it is >>>> guarded inside an #if NTDDI_VERSION >= NTDDI_WIN7 section. >>>> >>>> Jacek, could you indicate whether this needs to be fixed in >>>> mingw-w64-headers or in wine-gecko itself? >>> I guess we should define NTDDI_VERSION when building libuuid.a, so this >>> would be mingw-w64-crt problem. I will look at this tomorrow, thanks for >>> the research. >> Please review the attached patch. >> >> Jacek > Patch is ok.
Committed as r6267. > Shouldn't we set here additional _WIN32_WINNT to 0xffff > (or something equivalent), too? We might want to use fantasy > high-value for NTDDI_VERSION here too? Sounds like a good idea. Jacek ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
