> > -----Original Message----- > > From: Erik van Pienbroek [mailto:[email protected]] > > Sent: Thursday, September 12, 2013 1:00 PM > > To: [email protected] > > Subject: Re: [Mingw-w64-public] mingw-w64 v3 release calling for > > testers > > > > Koehne Kai schreef op do 12-09-2013 om 06:51 [+0000]: > > > > As there are no macros inside > > > > mingw-w64 which identify the svn revision all I could came up with > > > > is a '__MINGW64_VERSION_MAJOR < 3' conditional as best possible > > solution. > > > > > > So which toolchains / Mingw-w64 versions would still break with the > > "VERSION_MAJOR < 3" check? > > > > I would expect that such a conditional would break all v3/trunk > > snapshots predating r6215, but I haven't verified this yet > > > > > What I care most about is that compilation still succeeds with the > > > toolchains > > we 'officially' shipped and endorsed in the Qt SDK at one point. That is: > > > > > > mingw-builds x32-4.8.0-release-posix-dwarf-rev2 using revision 5540 > > > mingw-builds x32-4.7.2-release-posix-sjlj-rev8 using revision > > > 5796 > > > > I don't know whether these toolchains are v2 or v3/trunk based. If it > > is v3/trunk based, you could try to apply the patch locally on your > > environment and see if it really does break compilation for you. > > The above toolchains work just fine with the patches ... However, with the > > http://sourceforge.net/projects/mingw- > w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw- > builds/4.8.1/threads-win32/dwarf/x32-4.8.1-release-win32-dwarf-rev0.7z
Toolchain niXman provided I still get undefined symbol errors for IID_IFileDialogHelpers ... ./.obj\debug_shared\qwindowsdialoghelpers.o: In function `ZN36QWindowsNativeFileDialogEventHandler6c reateEP28QWindowsNativeFileDialogBase': D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:833: undefined r eference to `IID_IFileDialogEvents' ./.obj\debug_shared\qwindowsdialoghelpers.o: In function `ZN36QWindowsNativeFileDialogEventHandler14 QueryInterfaceERK5_GUIDPPv@12': D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:791: undefined r eference to `IID_IFileDialogEvents' ./.obj\debug_shared\qwindowsdialoghelpers.o: In function `ZN28QWindowsNativeFileDialogBase6createEN1 8QFileDialogOptions10AcceptModeERK28QWindowsFileDialogSharedData': D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:1508: undefined reference to `IID_IFileOpenDialog' D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:1514: undefined reference to `IID_IFileSaveDialog' collect2.exe: error: ld returned 1 exit status jom: D:\dev\qt\qt-dev\mingw-builds-32-4.8.1-posix-dwarf\qtbase\src\plugins\platforms\windows\Makefil e.Debug [..\..\..\..\plugins\platforms\qwindowsd.dll] Error 1 jom: D:\dev\qt\qt-dev\mingw-builds-32-4.8.1-posix-dwarf\qtbase\src\plugins\platforms\windows\Makefil e [debug] Error 2 Indeed the IID_IFile* symbols are not exported anywhere? Anyhow, the patch looks fine to me, though I assume "__IShellEnumItems_INTERFACE_DEFINED__" was just a typo, and you could remove it from the check. Do you want to put it on codereview.qt-project.org, qtbase dev branch? Regards Kai PS: Sorry for the incomplete mail, Outlook once in a while tricks me by the 'Ctrl+Enter' shortcut ... ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
