Koehne Kai schreef op do 12-09-2013 om 06:51 [+0000]: > > As there are no macros inside > > mingw-w64 which identify the svn revision all I could came up with is a > > '__MINGW64_VERSION_MAJOR < 3' conditional as best possible solution. > > So which toolchains / Mingw-w64 versions would still break with the > "VERSION_MAJOR < 3" check?
I would expect that such a conditional would break all v3/trunk snapshots predating r6215, but I haven't verified this yet > What I care most about is that compilation still succeeds with the toolchains > we 'officially' shipped and endorsed in the Qt SDK at one point. That is: > > mingw-builds x32-4.8.0-release-posix-dwarf-rev2 using revision 5540 > mingw-builds x32-4.7.2-release-posix-sjlj-rev8 using revision 5796 I don't know whether these toolchains are v2 or v3/trunk based. If it is v3/trunk based, you could try to apply the patch locally on your environment and see if it really does break compilation for you. > Ideally every Qt version should still compile which every toolchain using > 'newer' headers, but that's just a goal. > PS: Is it possible to put the svn revision in a macro, so that we can use it > in future incidents like that? I totally agree, it has already happened to us Fedora folks on multiple occasions that we had to manually patch downstream packages due to changes in mingw-w64 and where it is hard to remain compatible with older mingw-w64 releases/snapshots. Regards, Erik ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
