Koehne Kai schreef op vr 13-09-2013 om 09:21 [+0000]:
> > The above toolchains work just fine with the patches ... However, with the
> >
> > http://sourceforge.net/projects/mingw-
> > w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-
> > builds/4.8.1/threads-win32/dwarf/x32-4.8.1-release-win32-dwarf-rev0.7z
>
> Toolchain niXman provided I still get undefined symbol errors for
> IID_IFileDialogHelpers ...
>
> ./.obj\debug_shared\qwindowsdialoghelpers.o: In function
> `ZN36QWindowsNativeFileDialogEventHandler6c
> reateEP28QWindowsNativeFileDialogBase':
> D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:833:
> undefined r
> eference to `IID_IFileDialogEvents'
> ./.obj\debug_shared\qwindowsdialoghelpers.o: In function
> `ZN36QWindowsNativeFileDialogEventHandler14
> QueryInterfaceERK5_GUIDPPv@12':
> D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:791:
> undefined r
> eference to `IID_IFileDialogEvents'
> ./.obj\debug_shared\qwindowsdialoghelpers.o: In function
> `ZN28QWindowsNativeFileDialogBase6createEN1
> 8QFileDialogOptions10AcceptModeERK28QWindowsFileDialogSharedData':
> D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:1508:
> undefined
> reference to `IID_IFileOpenDialog'
> D:/dev/qt/qt-dev/src/qtbase/src/plugins/platforms/windows/qwindowsdialoghelpers.cpp:1514:
> undefined
> reference to `IID_IFileSaveDialog'
> collect2.exe: error: ld returned 1 exit status
> jom:
> D:\dev\qt\qt-dev\mingw-builds-32-4.8.1-posix-dwarf\qtbase\src\plugins\platforms\windows\Makefil
> e.Debug [..\..\..\..\plugins\platforms\qwindowsd.dll] Error 1
> jom:
> D:\dev\qt\qt-dev\mingw-builds-32-4.8.1-posix-dwarf\qtbase\src\plugins\platforms\windows\Makefil
> e [debug] Error 2
>
> Indeed the IID_IFile* symbols are not exported anywhere?
Those should already be fixed with mingw-w64 r6267:
http://sourceforge.net/p/mingw-w64/code/6267/ (but requires a rebuild of
the crt)
> Anyhow, the patch looks fine to me, though I assume
> "__IShellEnumItems_INTERFACE_DEFINED__" was just a typo, and you could remove
> it from the check.
I'm not sure whether it was used in older mingw-w64 snapshots or the
mingw.org toolchain..so to be on the safe side I left it in
> Do you want to put it on codereview.qt-project.org, qtbase dev branch?
Here you are: https://codereview.qt-project.org/#change,65402
BTW, the previous fixes I mentioned were also already put up for review
( https://codereview.qt-project.org/#change,64144 )
but got stuck waiting for somebody to approve them. Apparently you
missed this review ticket and created a
new review ticket containing the same fix yourself:
https://codereview.qt-project.org/#change,64330
Therefore I just marked my old review ticket as 'abandoned'.
Regards,
Erik
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
