Hi Developers,
I think we should carefully consider risks and chances for the cover art
support merge.
My impression is that the branch has a good overall quality and is a real
benefit for a upcoming 1.12 version.
What are the points of risks, that makes this different to other pull
requests.
Here a probably incomplete List:
1) Reading picture files of poor quality
2) Extracting pictures from audio Files using tag-lib
3) Displaying pictures
4) Writing users library
5) Performance regressions
6) Threading issues
Will re significant reduce these risk, if we have this PR another two years
as developers compile option or it is better to have this a part of a
public beta phase?
for 1)
here we have to rely on the Qt library. We can't do much if the picture
byte stream is invalid or can we?
for 2)
We have plenty of Tag-lib issues in the past and have seen other music
player apps to use a quarantine process because of this. I still get
constantly reports that my Rhythmbox quarantine process crashes an a recent
Ubuntu 14.4 installation. I do not know why but that is not a good idea to
pull that to Mixxx.
Is there a chance for a quarantine process for Mixxx 1.12? I have started
it a while ago, but get stucked. Any Ideas?
for 3)
Displaying Pixamps is a regular task of Qt and Mixxx and should be not
produce any GPU issues, since no openGL is involved.
for 4)
IMHO the current scheme is fine.
for 5)
These are easy to find and fix issues during the test phase
for 6)
Do we expect some? Such things should be discovered during a review.
Finding them by testing is hard.
For me, it sounds that this can be part of 1.12 if we have a solution for
taglib crashes.
Kind regards,
Daniel
2014-10-16 14:49 GMT+02:00 Owen Williams <owilli...@mixxx.org>:
> That model has not worked well in the past. It doesn't matter how many
> warnings there are, people will see "album art!", turn it on, and then
> get angry if/when it crashes.
>
> The new model I'd like to propose is:
> * Enable an unstable-but-desirable feature (like cover art) by default
> in development and nightly builds.
> * Disable it for release builds.
>
> I think this will prevent code rot, which was the biggest problem in the
> past with optional compile-time features. Everyone doing development
> will be using the feature and seeing any bugs it has. But then the
> release is still pristine and won't be compromised. Once the feature is
> stable, we can flip the flag and allow the feature to go to release.
>
> This does require that the compile flag is robust. There have been
> problems in the past with vinyl control, which is enabled for most
> builds but disabled for App Store builds. Things work great in
> development, and then the release build turns out to be broken. Having
> the buildbot should help prevent that -- we should set up a target to
> create release builds and run the tests, but not actually make them
> available for download.
>
> Owen
>
> On Thu, 2014-10-16 at 09:53 +0300, Tuukka Pasanen wrote:
> > Hello,
> > Ok I'm totally with this but I also understand RJ concerns about
> > hitting unwanted behavior.
> > Could this be integrated and only turned on if user makes it with BIG
> > FAT WARNING about
> > it is little bit experimental and polish it to 1.13?
> >
> > Tuukka
> >
> > 2014-10-12 15:13 GMT+03:00 Max Linke <max_li...@gmx.de>:
> > > That is exactly how it works. Currently ew only support local covers.
> We have
> > > some code to also download covers from amazon but I'm not sure if that
> will make
> > > it.
> > >
> > > Here is the algorithm that decides which cover we are loading.
> > >
> > > // Search Strategy
> > > // 0. If we have just one file, we will get it.
> > > // 1. %track-file-base%.jpg in the track directory for
> %track-file-base%.mp3
> > > // 2. %album%.jpg
> > > // 3. cover.jpg
> > > // 4. front.jpg
> > > // 5. album.jpg
> > > // 6. folder.jpg
> > > // 7. anything else found in the folder (get the smallest one)
> > >
> > > On Sun, 12 Oct 2014 11:22:17 +0300
> > > Tuukka Pasanen <pasanen.tuu...@gmail.com> wrote:
> > >
> > >> Hello,
> > >> Does this support scenario when you have used something like Beets
> > >> (http://beets.radbox.org/) and allready have cover.jpg (or something)
> > >> in every directory that contains music? It's nice to have somekind of
> > >> downloader but there should be also support people like me who like to
> > >> organize their music in specific way and have cover art in hand..
> > >>
> > >> Tuukka
> > >>
> > >>
> ------------------------------------------------------------------------------
> > >> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> > >> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS
> Reports
> > >> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> > >> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> > >> http://p.sf.net/sfu/Zoho
> > >> _______________________________________________
> > >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> > >> http://mixxx.org
> > >>
> > >>
> > >> Mixxx-devel mailing list
> > >> Mixxx-devel@lists.sourceforge.net
> > >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> > >
> > >
> ------------------------------------------------------------------------------
> > > Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> > > Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS
> Reports
> > > Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> > > Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> > > http://p.sf.net/sfu/Zoho
> > > _______________________________________________
> > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> > > http://mixxx.org
> > >
> > >
> > > Mixxx-devel mailing list
> > > Mixxx-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> >
> >
> ------------------------------------------------------------------------------
> > Comprehensive Server Monitoring with Site24x7.
> > Monitor 10 servers for $9/Month.
> > Get alerted through email, SMS, voice calls or mobile push notifications.
> > Take corrective actions from your mobile device.
> > http://p.sf.net/sfu/Zoho
> > _______________________________________________
> > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> > http://mixxx.org
> >
> >
> > Mixxx-devel mailing list
> > Mixxx-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> >
> >
>
>
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
