Hi,
The newly merged album art code in master is missing implementation for Opus
codec, causing linker errors if libopus is detected and enabled.
I added following to my hack branch to make it compile without explicitly
disabling opus codec, but I’m not at all sure about the code.
http://tuohela.net/irc/opus-fix.txt <http://tuohela.net/irc/opus-fix.txt>
Sorry no pull request, because I’m not sure how this should be tested. I guess
people who actually committed the code should test and fix this, because they
should know what to test? Also how to test this properly with old and new
taglib versions?
Tested with my large library and it seems to be OK. I think there was an issue
with track analysis/waveform loading after first albumart import (no track had
analysis data available during that session), but now when I restarted mixxx
this is gone.
The bug with library field layout is very annoying, especially because it
requires one extra restart of mixxx (when you hit the bug, you’ll lose any
changes made to the layout again until first restart when the state is changed,
the layout changes stick only after you have restarted mixxx once). Remember
this is not a bug directly in albumart branch, it’s old bug with storing
library column layouts which has just emerged again when number of options
changed.
*hile*------------------------------------------------------------------------------
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
