Is taglib really that crash-prone? Is this really a common issue? I think crashing on totally crap data is not completely unreasonable as long as we can figure out some way of making it debuggable.
I don't see how processing files for cover art is any different than processing files for audio data, and we don't process audio data in a separate kernel process. On Sat, 2014-10-18 at 15:09 -0400, RJ Ryan wrote: > The main limitation with QtConcurrent is that it uses a single global > thread pool -- and currently we use 4 worker threads in our global > thread pool (for parsing 3rd-party libraries, etc). There is no notion > of auto-scaling or the ability for sensing whether we are overloading > the system inherent in QtConcurrent -- it's just a wrapper around a > thread pool. For something as common and compute heavy as processing > cover art we need more deliberate control. > > TagLib crashes will happen given the extreme diversity of > library-from-hell files out there. We really do need a > separate-process isolation feature for processing untrusted data but > I'm pretty sure we don't have time for that for 1.12 if we want to > release in 2014 :). > > > > > On Fri, Oct 17, 2014 at 7:33 PM, Daniel Schürmann <dasch...@mixxx.org> wrote: > > Am 18.10.2014 um 00:31 schrieb Max Linke: > >> I haven't noticed any taglib crashes with mixxx. Plus the covers are all > >> extracted in seperate threads. > > I have not experienced any crashes during the tests as well, so the > > issue is hopefully none. > > I was just trying to collect the point that might be risky. > > By the way: Segfaults in a extra thread will have the same effect than a > > segfault in the main thread, Mixxx will crash. > > So we can either rely on the quality of the new taglib version, or setup > > a quarantine process, that read the tags. > > > > > > ------------------------------------------------------------------------------ > > Comprehensive Server Monitoring with Site24x7. > > Monitor 10 servers for $9/Month. > > Get alerted through email, SMS, voice calls or mobile push notifications. > > Take corrective actions from your mobile device. > > http://p.sf.net/sfu/Zoho > > _______________________________________________ > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > http://mixxx.org > > > > > > Mixxx-devel mailing list > > Mixxx-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > ------------------------------------------------------------------------------ > Comprehensive Server Monitoring with Site24x7. > Monitor 10 servers for $9/Month. > Get alerted through email, SMS, voice calls or mobile push notifications. > Take corrective actions from your mobile device. > http://p.sf.net/sfu/Zoho > _______________________________________________ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
