Hi Mike, looks good to me. I am just not sure about the new stdout message "Setting max-jobs to 4" It appears when --max-jobs is not used (ok), but also when it is used without a parameter. In the latter case I would only print this message if the number of CPU cores is higher.
Gerd ________________________________________ Von: mkgmap-dev <[email protected]> im Auftrag von Gerd Petermann <[email protected]> Gesendet: Mittwoch, 14. Februar 2018 19:38:06 An: Development list for mkgmap Betreff: Re: [mkgmap-dev] max-jobs patch Hi Mike, okay, I'll try it tomorrow. Gerd ________________________________________ Von: mkgmap-dev <[email protected]> im Auftrag von Mike Baggaley <[email protected]> Gesendet: Mittwoch, 14. Februar 2018 18:30:28 An: 'Steve Ratcliffe'; [email protected] Betreff: Re: [mkgmap-dev] max-jobs patch I tried renaming the java library to force a failure and got a java error "Error occurred during initialization of VM" before any mkgmap code was executed, so to be on the safe side, I have removed that code and amended the message in the attached patch. Regards, Mike -----Original Message----- From: Steve Ratcliffe [mailto:[email protected]] Sent: 13 February 2018 23:01 To: [email protected] Subject: Re: [mkgmap-dev] max-jobs patch Hi Mike > I could take out that bit of code, which is just determining how > much physical memory is installed, so that mkgmap won't suggest that the > user increases the available heap too much. It isn't used in determining a > value for maxjobs. Since it is just used for an informational message, you could just surround it with a try/catch block. Then if it doesn't exist on a particular it isn't a problem when using the downloaded pre-compiled distribution. Of course it would fail to compile on such a platform, but then hopefully someone will let us know and we can decide what to do then. Steve _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev _______________________________________________ mkgmap-dev mailing list [email protected] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
