2011/10/17 Kalev Lember <[email protected]>:
> On 10/16/2011 11:18 AM, Ludovic Rousseau wrote:
>> Hello Kalev,
>>
>> Some more questions :-)
>>
>> 2011/6/25 Kalev Lember <[email protected]>:
>>> diff --git a/PCSC/etc/pcscd.service.in b/PCSC/etc/pcscd.service.in
>>> new file mode 100644
>>> index 0000000..4800d32
>>> --- /dev/null
>>> +++ b/PCSC/etc/pcscd.service.in
>>> @@ -0,0 +1,13 @@
>>> +[Unit]
>>> +Description=PC/SC Smart Card Daemon
>>> +Requires=pcscd.socket
>>> +After=syslog.target
>
> (According to Lennart, After=syslog.target is no longer necessary with
> the version of systemd in Fedora 16, so we could probably drop this line.)

Line removed in revision 6060.

>>> +
>>> +[Service]
>>> +ExecStart=@sbindir_exp@/pcscd -f
>>> +ExecReload=@sbindir_exp@/pcscd -H
>>> +StandardOutput=syslog
>
> (... and the same as above about StandardOutput=syslog: stdout and
> stderr should now be connected to syslog by default.)

The default value for systemd-29 is inherit. Debug lines are not sent to syslog.
I will remove this line after systemd-37 has migrated to
Debian/testing and the default has changed.

>>> +
>>> +[Install]
>>> +WantedBy=multi-user.target
>>> +Also=pcscd.socket
>>
>> Why do you have "WantedBy=multi-user.target"?
>> The idea is to have pcscd started on demand using the socket
>> activation mechanism. I do not want to have pcscd started at boot, but
>> only on demand.
>> So I propose to remove the line.
>
> The [Install] section is used when someone runs 'systemctl enable' /
> 'systemctl disable' on the pcscd.service file. When a user runs the
> command, the WantedBy=multi-user.target line adds the pcscd.service
> dependency to the multi-user.target, effectively marking pcscd to always
> start up on system boot. I can imagine that some people would want to do
> that, but I'm personally fine with killing that use case.

OK. Remove in revision 6062.

>> I am no sure the line "Also=pcscd.socket" is needed. I removed it
>> without any problem.
>
> Like the rest of the [Install] section in pcscd.service, this is only
> used when someone runs 'systemctl enable/disable pcscd.service'. The
> Also=pcscd.socket line also enables pcscd.socket when pcscd.service is
> enabled. That way, people can run 'systemctl enable pcscd.service'
> instead of 'systemctl enable pcscd.socket' and things would
> automagically still work correctly.
>
> I'd certainly vote for keeping this one.

OK. I will keep it.

Bye,

-- 
 Dr. Ludovic Rousseau

_______________________________________________
Muscle mailing list
[email protected]
http://lists.drizzle.com/mailman/listinfo/muscle

Reply via email to