On Sun, Jan 25, 2026 at 06:09:39PM +0800, Kevin J. McCarthy wrote:
+static int is_from_reverse_scan (const char * const bos,
+ char *path, size_t pathlen,
+ struct tm *tm)
+{
+ const char *cur = bos;
+
that assignment is pointless.
+ cur = strchr (bos, '\0');
+
that's kinda inefficient, as strchr already checks for null.
faster and arguably more legible would be `bos + strlen(bos)`.
also, as this is arguably performance-critical code, it may make sense
to pass in the length from the layer above.
+ { "mbox_lax_parse", DT_BOOL, R_NONE, {.l=OPTMBOXLAXPARSE}, {.l=1} },
+ /*
+ ** .pp
+ ** This version of the mbox parser allows more loose return path values in
the
+ ** From_ line.
+ */
this is way too cryptic and unspecific. without knowing the context, one
would be left guessing why one might want to touch it.
but more generally, i'm not convinced that an option is a terribly good
idea. once one sets it, the silent failures will resume, no?
