On Mon, Jan 26, 2026 at 06:56:00PM +0100, Oswald Buddenhagen via Mutt-dev wrote:
On Mon, Jan 26, 2026 at 02:53:43PM +0100, Vincent Lefevre wrote:I suspect that at that time, most software did not care about the exact format and just considered the first 5 characters.that's actually quite reasonable ...In any case, *all* lines starting with "From " in the body were quoted... because this.mutt's own mbox(5) sort of implies that this must happen, which is also the only reasonable thing.it's reasonable to complain about errors in the envelope info, but this shouldn't preclude the line from being treated as a message separator, or affect whether the message is considered fundamentally valid.so by extension this patch must be considered over-engineered for the purpose.
Perhaps not entirely.We could change is_from() to return true for a line starting with "From " followed by something, parsable or not. But also change it to use the new reverse_scan() function, since that parses out a date/time in cases where the old scanner would not.
Something roughly like:
if (mutt_strncmp ("From ", s, 5) != 0)
return 0;
s = next_word (s); /* skip over the From part. */
if (!*s)
return 0;
if (is_from_reverse_scan (s, path, pathlen, &tm) && tp)
{
tm.tm_isdst = -1;
*tp = mutt_mktime (&tm, 0);
}
return 1;
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
