On Sun, Jan 25, 2026 at 02:44:05PM +0100, Alejandro Colomar wrote:
It's a bit difficult to review this patch, as the diff merges refactors with behavior changes. It might be better to first have a patch that splits code into helper functions and other similar refactors, and then have the patch that changes behavior be minimal.
That's a fair complaint. I actually wrote most of these two patch sets a couple years ago, and then forgot about them :-D. At the time I didn't have a whole group of people helping review, so didn't take care to make them easy to review.
I'll try to split the refactor out in the next patch set version, after I fix the stable release bug.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
