Re: [PATCH 1/2] Add $mbox_lax_parse, default set, to allow for verbose return paths.

[Kevin J. McCarthy]

On Sun, Jan 25, 2026 at 11:59:42AM +0100, Oswald Buddenhagen via Mutt-dev wrote:

On Sun, Jan 25, 2026 at 06:09:39PM +0800, Kevin J. McCarthy wrote:

+static int is_from_reverse_scan (const char * const bos,
+                                 char *path, size_t pathlen,
+                                 struct tm *tm)
+{
+  const char *cur = bos;
+

that assignment is pointless.

Oops.  :-)  I'll combine that with the next line.

+  cur = strchr (bos, '\0');
+

that's kinda inefficient, as strchr already checks for null.
faster and arguably more legible would be `bos + strlen(bos)`.

Thanks I'll make that change.

+  { "mbox_lax_parse",        DT_BOOL, R_NONE, {.l=OPTMBOXLAXPARSE}, {.l=1} },
+  /*
+  ** .pp
+  ** This version of the mbox parser allows more loose return path values in 
the
+  ** From_ line.
+  */

this is way too cryptic and unspecific. without knowing the context, one would be left guessing why one might want to touch it.

but more generally, i'm not convinced that an option is a terribly good idea.

For now, perhaps I can keep the old parser code around for a while and
we can parameterize is_from() if needed in the future?

Yes, that's good feedback. I actually wondered about whether it was appropriate to make a config option too. I worried someone out there might scream that the is_from wasn't following the spec, or there might turn out to be a good reason to stay strict.

once one sets it, the silent failures will resume, no?

Not entirely, the #415 changes abort now when the message is
content-length delimited.

--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

signature.asc
Description: PGP signature