Follow-up Comment #1, bug #15155 (project mypaint):
Looking good with the icon and the action information. I also wanted to make
Copy the default action but forgot to add it to the list, did you read my
mind? :-) Within the current group, however, the action is always "move",
maybe the cursor can reflect this too? (I will also accept your patch without
this fixed)
The pixbuflist is also used in the background selector. Your patch makes the
pixbufs there draggable, and you get an exception when you try - this really
should be fixed.
I didn't know you could use integer division (//) without the "from future"
import. Looks like python2.4 also supports this, so it should be fine.
About the commit message, I prefer the "submodule: change this" convention,
so I suggest you to change it to "brush selector: ui feedback, improve
layout". And while you're at it, it would be nice to have the link to this
bugreport, two lines below the main commit message.
(Quick review, if I get time I will see if I can help. There are some open
issues and bugfixes coming in, release candidate will probably be more
towards the weekend, not today/tomorrow.)
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?15155>
_______________________________________________
Nachricht geschickt von/durch Gna!
http://gna.org/
_______________________________________________
Mypaint-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/mypaint-bugs
