On Wed, 8 Feb 2023 14:40:48 GMT, Jaikiran Pai <[email protected]> wrote:

>> Conor Cleary has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8296410: java/net/httpclient/http2/IdleConnectionTimeoutTest.java 
>> intermittent failure
>
> Thank you for checking Daniel; yes I was being lazy about pulling the PR 
> locally :)

Thank you for also reviewing @jaikiran , I appreciate you taking the time! I'll 
take some time today to respond to your feedback properly.

But also I apologise for the confusing version control issues with this 
particular PR. I learned a lot about _how not to_ organise my local changes 
with this particular changeset. A lot of issues stemmed from local squashing of 
commits for my own organisation however for future reference one should (as in 
myself) take care not to squash commits already present on an open PR.

-------------

PR: https://git.openjdk.org/jdk/pull/12028

Reply via email to